Changing all the references from Flash to OpenFL.
#2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ive been putting this off because it will likely cause merge conflicts with almost every other active PR, but let's try it. gimme some time, first |
Geokureli
reviewed
Jun 7, 2023
flixel/input/mouse/FlxMouse.hx
Outdated
| import openfl.geom.Matrix; | ||
| import openfl.geom.Point; | ||
| import openfl.ui.MouseCursor; | ||
| import openfl.ui.MouseCursorData; |
There was a problem hiding this comment.
looks like flash is failing here because there is no openfl.ui.MouseCursorData
There was a problem hiding this comment.
I think openfl doesn't have support for that classes but we can find a workaround ig?
There was a problem hiding this comment.
https://github.com/HaxeFlixel/flixel/blob/dev/flixel/system/macros/FlxDefines.hx#L144
I think FLX_NATIVE_CURSOR is only used with flash, so lets just use flash.ui.MouseCursorData
|
Thanks, hopefully this fixes most macro issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title tells everything this commit do.